Arik Hadas has posted comments on this change. Change subject: core: Move status check methods from VM to VMStatus ......................................................................
Patch Set 5: Verified rebased, verified @Roy: 1. I mistakenly thought that 'guest' refer to some other guest in the host and not to the VM, my bad.. 2. I still think that the suggested names are less standard from OOP perspective, but it is more important that those methods will reside in VMStatus than to have the most-reflective names so I changed it as you wanted 3. the isGuestUp method remain for now, it should be removed, but this will be made in a different patch now can I get +1? :) -- To view, visit http://gerrit.ovirt.org/10795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82b4f109751773ff2d46407ccea26ea0be2661f5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
