Tal Nisan has posted comments on this change.
Change subject: core: improve logging
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 171: // initialize configuration utils to use DB
Line 172: Config.setConfigUtils(new DBConfigUtils());
Line 173:
Line 174: _resourceManger = new VDSBrokerFrontendImpl();
Line 175: log.info("Initialized VDSBrokerFrontend");
I think this can be put in a default constructor of VDSBrokerFrontendImpl like
in AsyncTaskManager for instance, isn't it better to keep this convention?
Line 176:
Line 177: CpuFlagsManagerHandler.InitDictionaries();
Line 178:
Line 179: // ResourceManager res = ResourceManager.Instance;
--
To view, visit http://gerrit.ovirt.org/10823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaea9c16e9913cdee4eef88de920e87bde8bc6b5d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
