Allon Mureinik has posted comments on this change.
Change subject: core: Improve logs in DbUserCacheManager
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
See minor comment inline, for future reference.
will rebase and merge in a couple of minutes.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 28: import org.ovirt.engine.core.utils.timer.OnTimerMethodAnnotation;
Line 29: import org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl;
Line 30:
Line 31: public class DbUserCacheManager {
Line 32: private static Log log =
LogFactory.getLog(DbUserCacheManager.class);
might as well make it final while you're touching this data member
[although not necessarily in this patch]
Line 33: private static DbUserCacheManager _instance = new
DbUserCacheManager();
Line 34: private String jobId;
Line 35: private boolean initialized = false;
Line 36:
--
To view, visit http://gerrit.ovirt.org/10825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46c0cffd1280f2781000b608496f1e4104faca8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
