Tal Nisan has posted comments on this change.
Change subject: core: ImagesHandler cleanup: Logged empty catch
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
Minor comment, up to you if you'd take it
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 407: VDSCommandType.GetImageInfo,
Line 408: new
GetImageInfoVDSCommandParameters(storagePoolId, storageDomainId, imageGroupId,
Line 409:
image.getImageId())).getReturnValue();
Line 410: } catch (Exception e) {
Line 411: log.debug("Unable to get image info from from storage.",
e);
Totally a matter of style, but I'd also add return null
Although fromIrs has to be null at this point, this is just in case someone
make a change to it's value or add more logic/logging on fromIrs after the
try/catch block and may get a NPE
Line 412: }
Line 413: return fromIrs;
Line 414: }
Line 415:
--
To view, visit http://gerrit.ovirt.org/10998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie600ed85f38f7de1b36e461517183851185bc9c2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
