Vered Volansky has posted comments on this change. Change subject: core: MoveVm vmDown validation ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java Line 68: retValue = retValue Line 69: && validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) Line 70: && validate(new VmValidator(getVm()).vmDown()); Line 71: Line 72: // check that vm is down and images are ok Revise comment. It'll be confusing in the future. Line 73: // not checking storage domain, there is a check in Line 74: // CheckTemplateInStorageDomain later Line 75: VmHandler.updateDisksFromDb(getVm()); Line 76: List<DiskImage> diskImages = ImagesHandler.filterImageDisks(getVm().getDiskMap().values(), false, false); -- To view, visit http://gerrit.ovirt.org/11017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3d1d48192be7256ac55a145e7cb058480901ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
