Ravi Nori has posted comments on this change.
Change subject: engine: Removing using of latch all around a code
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
Line 127:
returnValues.addAll(ThreadPoolUtil.invokeAll(canDoActionTasks));
Line 128: }
Line 129: }
Line 130:
Line 131: private Callable<VdcReturnValueBase>
buildCanDoActionAsyncroniousely(
While we are at it, can we fix the typo in method name. It has to be
Asynchronously
Line 132: final int currentCanDoActionId, final int totalSize) {
Line 133: return new Callable<VdcReturnValueBase>() {
Line 134:
Line 135: @Override
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java
Line 39: @Override
Line 40: public V call() {
Line 41: ISingleAsyncOperation operation =
_factory.createSingleAsyncOperation();
Line 42: operation.execute(currentEventId);
Line 43: return null;
Why do we need to declare this class as generic if we are always returning null?
Line 44: }
Line 45: }
Line 46:
--
To view, visit http://gerrit.ovirt.org/11037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ffc04f7abf57f3d27322a5615f89d07dee16ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
