Yair Zaslavsky has posted comments on this change.
Change subject: engine : User is UNKNOWN in async task completion events
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 137: _parameters = parameters;
Line 138: if (parameters.getParametersCurrentUser() != null) {
Line 139: setCurrentUser(parameters.getParametersCurrentUser());
Line 140: } else {
Line 141:
setCurrentUser(SessionDataContainer.getInstance().addUserToThreadContext(parameters.getSessionId(),
true));
Hi Ravi - can you add some comment when parameters.getParametersCurrentUser()
can be set to null?
For example -
When Backend.endAction is called -
Does the thread local contain a user? the parameters probably include a user as
it was passed to the "task parameters" according to this patch.
Line 142: }
Line 143: // correlation ID thread local variable is set for non
multi-action
Line 144: if (!parameters.getMultipleAction()) {
Line 145:
ThreadLocalParamsContainer.setCorrelationId(parameters.getCorrelationId());
--
To view, visit http://gerrit.ovirt.org/10896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0904f9f6d9432ecac1cebee3790eae902a1329a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
