Alona Kaplan has posted comments on this change.
Change subject: webadmin: Select english when browser is other locale
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
Line 77: public void onChange(ChangeEvent event) {
Line 78: String localeName =
localeBox.getValue(localeBox.getSelectedIndex());
Line 79: String localeString = ""; //$NON-NLS-1$
Line 80:
Line 81: if (!DEFAULT.equals(localeName)) {
This 'if' is redundant, localeName can't be default cause default is not added
to the locale box.
Line 82: localeString = "?locale=" + localeName;
//$NON-NLS-1$
Line 83: }
Line 84: Window.open(FrontendUrlUtils.getCurrentPageURL() +
localeString, "_self", ""); //$NON-NLS-1$ //$NON-NLS-2$
Line 85: }
--
To view, visit http://gerrit.ovirt.org/11047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1b31fe65c306602c45c85857ccc7392e16dc8d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
