Oved Ourfali has posted comments on this change.

Change subject: core: Adding ldap server ordering algorithms factory
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/serverordering/LdapServersOrderingAlgorithm.java
Line 6: public abstract class LdapServersOrderingAlgorithm {
Line 7: 
Line 8:     protected abstract void replaceLdapServerInListImpl(URI server, 
List<URI> restOfServers);
Line 9: 
Line 10:     public void replaceLdapServerInList(URI server, List<URI> servers) 
{
change name to reorder.
Line 11:        if (servers.remove(server)) {
Line 12:            replaceLdapServerInListImpl(server, servers);
Line 13:        }
Line 14:     }


--
To view, visit http://gerrit.ovirt.org/11063
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0904f9f6d9431ecac1cebee2790eae902a1329c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to