Alex Lourie has posted comments on this change.

Change subject: packaging: Application Mode option in installer
......................................................................


Patch Set 6: Looks good to me, but someone else must approve

(1 inline comment)

Thank you!

Please make sure that this works properly.

....................................................
File packaging/fedora/setup/engine-setup.py
Line 354:                 "DEFAULT_VALUE"   : 
basedefs.CONST_DEFAULT_APPLICATION_MODE,
Line 355:                 "MASK_INPUT"      : False,
Line 356:                 "LOOSE_VALIDATION": False,
Line 357:                 "CONF_NAME"       : "APPLICATION_MODE",
Line 358:                 "USE_DEFAULT"     : 
basedefs.USE_DEFAULT_APPLICATION_MODE_WITHOUT_PROMPT,
That is actually a nice trick!
Line 359:                 "NEED_CONFIRM"    : False,
Line 360:                 "CONDITION"       : False}]
Line 361:          ,
Line 362:          "LOCAL_DB": [


--
To view, visit http://gerrit.ovirt.org/9991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Ronen Angluster <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to