Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add DC column to main tab Cluster view
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
+1 for frontend;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
Line 80: @Column(name = "storage_pool_id")
Line 81: @Type(type = "guid")
Line 82: private NGuid storagePool;
Line 83:
Line 84: @Size(max = BusinessEntitiesDefinitions.DATACENTER_NAME_SIZE)
not sure we need size validation for a read only field
Line 85: @Column(name = "storage_pool_name")
Line 86: private String storagePoolName;
Line 87:
Line 88: @Column(name = "max_vds_memory_over_commit")
Line 358: if (other.selection_algorithm != null)
Line 359: return false;
Line 360: } else if
(!selection_algorithm.equals(other.selection_algorithm))
Line 361: return false;
Line 362: if (storagePool == null) {
please change storagePool to storagePoolId, that's confusing (IMHO it's not a
clean-up and can be a part of this patch) -> the getter is getStoragePoolId
Line 363: if (other.storagePool != null)
Line 364: return false;
Line 365: } else if (!storagePool.equals(other.storagePool))
Line 366: return false;
--
To view, visit http://gerrit.ovirt.org/11070
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5847d234e396fe8a83017fb25a5139f552e7c61b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
