Michael Kublin has posted comments on this change.
Change subject: core: Added log for storage connection error (#854210)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Same remarks.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1286: && vds.getstatus() !=
VDSStatus.NonOperational) {
Line 1287: log.warnFormat(
Line 1288: "vds {0} reported domain {1} as
in problem, moving the vds to status NonOperational",
Line 1289: vds.getvds_name(),
Line 1290: domainIdTuple);
The code is bad. Again, why audit log is added here? Line 1294 is moving host
to NonOperational, which is performing a call to SetNonOperationalVds command,
which is writtng appropriate audit log message. If a message is not written
correct it is means that a bug there.
Line 1291: AuditLogableBase logable = new
AuditLogableBase(vdsId);
Line 1292:
logable.AddCustomValue("failedStorageDomains", storageDomain.getstorage_name());
Line 1293: AuditLogDirector.log(logable,
AuditLogType.VDS_STORAGES_CONNECTION_FAILED);
Line 1294: ResourceManager
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
Line 30: switch (returnStatus) {
Line 31: case Done:
Line 32: case StoragePoolMasterNotFound:
Line 33: case StoragePoolTooManyMasters:
Line 34: case StoragePoolWrongMaster:
I will write in very political correct way: What is a reason for such change?
Line 35: logFaultInConnectionToMasterDomain();
Line 36: super.ProceedProxyReturnValue();
Line 37: break;
Line 38: default:
--
To view, visit http://gerrit.ovirt.org/9399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9b452741860e97de0725334e53e3c2de53b795c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
