Shireesh Anjal has posted comments on this change.
Change subject: engine: check if host exists with same name
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 303: returnValue = false;
Line 304: } else if(getDbFacade().getVdsDao().getByName(vdsName) !=
null) {
Line 305:
addCanDoActionMessage(VdcBllMessages.VDS_TRY_CREATE_WITH_EXISTING_PARAMS);
Line 306: returnValue = false;
Line 307: } else {
Similar check might be required on hostName as well. There is a unique
constraint on host_name field (vds_static_host_name_unique)
Line 308: returnValue = returnValue &&
validateSingleHostAttachedToLocalStorage();
Line 309:
Line 310: if (Config.<Boolean>
GetValue(ConfigValues.UseSecureConnectionWithServers)
Line 311: &&
!FileUtil.fileExists(Config.resolveCertificatePath())) {
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791d49b128126269d9b2b0c2e9bb35debf5a7ec
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
