Tal Nisan has posted comments on this change.
Change subject: core: Early return RemoveDiskCommand.canDoAction()
......................................................................
Patch Set 4: (1 inline comment)
In addition it might be a good idea to add a VM not down test
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
Line 66:
Line 67: /* Tests for canDoAction() flow */
Line 68:
Line 69: @Test
Line 70: public void testCanDoActionFlowVmNotDown() {
I think the method name is wrong, this should be testCanDoActionImageNotExist,
not VmNotDown..
Line 71: doReturn(null).when(cmd).getDisk();
Line 72: CanDoActionTestUtils.runAndAssertCanDoActionFailure(cmd,
Line 73:
VdcBllMessages.ACTION_TYPE_FAILED_VM_IMAGE_DOES_NOT_EXIST);
Line 74: }
--
To view, visit http://gerrit.ovirt.org/11012
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32eb51e9e3cee5920f90b8f1ff8a8148a10cf2f1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
