Allon Mureinik has uploaded a new change for review. Change subject: core: CreateAllSnapshotsFromVm preview validation ......................................................................
core: CreateAllSnapshotsFromVm preview validation In CreateAllSnapshotsFromVm, moved the validation that the VM is not in preview from ImagesHandler to SnapshotValidator, which is a more logical place for it. Note: This patch is part of a series of patches aimed at removing the preview validation from ImagesHandler altogether. Change-Id: Iaa60843e4bfe5684bd6fee15b49a24bc44c21bc1 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/11180/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java index 7f8b120..4593e60 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java @@ -288,7 +288,9 @@ List<DiskImage> disksList = getDisksList(); if (disksList.size() > 0) { VmValidator vmValidator = new VmValidator(getVm()); - result = validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) + SnapshotsValidator snapshotValidator = new SnapshotsValidator(); + result = validate(snapshotValidator.vmNotDuringSnapshot(getVmId())) + && validate(snapshotValidator.vmNotInPreview(getVmId())) && validate(vmValidator.vmNotDuringMigration()) && validate(vmValidator.vmNotRunningStateless()) && ImagesHandler.PerformImagesChecks(getVm(), @@ -299,7 +301,7 @@ true, true, true, - true, + false, true, true, disksList); -- To view, visit http://gerrit.ovirt.org/11180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaa60843e4bfe5684bd6fee15b49a24bc44c21bc1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
