Maor Lipchuk has posted comments on this change.
Change subject: core: VM is down check when adding template
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 164: .getCanDoActionMessages())) {
Line 165: return false;
Line 166: }
Line 167:
Line 168: if (!validateVmNotDuringSnapshot()) {
Would not it will be more readable to call it validateVMDuringSnapshot instead
using a double negative?
Line 169: return false;
Line 170: }
Line 171:
Line 172: if (getVm().getStatus() != VMStatus.Down) {
--
To view, visit http://gerrit.ovirt.org/11010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec2d9677765502ca6876b31835340d3c4fad5ae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
