Daniel Erez has uploaded a new change for review. Change subject: core: required space validation - destination domain ......................................................................
core: required space validation - destination domain LiveMigrateVmDisksCommand -> isValidSpaceRequirements: add destination domain name to canDoActionMessage (instead of using getStorageDomain() - prevents a NPE). Change-Id: I51e0be2ccf541ee435ae04814baeedf3c3373af3 Bug-Url: https://bugzilla.redhat.com/888316 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/11205/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java index 76bb66b..64b1e2b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java @@ -291,7 +291,7 @@ storage_domains destDomain = getStorageDomainById(destDomainId, storagePoolId); if (!StorageDomainSpaceChecker.isBelowThresholds(destDomain)) { - addCanDoActionMessage(String.format("$%1$s %2$s", "storageName", getStorageDomain().getstorage_name())); + addCanDoActionMessage(String.format("$%1$s %2$s", "storageName", destDomain.getstorage_name())); return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_TARGET_STORAGE_DOMAIN); } -- To view, visit http://gerrit.ovirt.org/11205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I51e0be2ccf541ee435ae04814baeedf3c3373af3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
