Yair Zaslavsky has posted comments on this change.
Change subject: engine: putIfAbsent in EnumUtils.valueOf is ignored.
......................................................................
Patch Set 1: Fails
Fails,
As suspected - NPE.
Add the following test to EnumUtilsTest:
public void testValueOf() {
assertEquals(EnumUtils.<EnumForTesting>valueOf(EnumForTesting.class, "ENUM1",
true),EnumForTesting.ENUM1);
}
--
To view, visit http://gerrit.ovirt.org/10956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41591e5da72b84bdb497b9ee7c88fbd72ecda827
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
