Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVm preview validation ......................................................................
core: RemoveVm preview validation In RemoveVm, moved the validation that the VM is not in preview from ImagesHandler to SnapshotValidator, which is a more logical place for it. Note: VM preview validation is done only if getForce()==true. This is done to keep consistency with the current behavior, which has been in place since this git repository was established. Whether or not it is correct is a different question, which warrants inspection in an additional patch. Note: This patch is part of a series of patches aimed at removing the preview validation from ImagesHandler altogether. Change-Id: If49d2094589c639736649ee2eadcd45df9872826 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If49d2094589c639736649ee2eadcd45df9872826 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
