Daniel Erez has uploaded a new change for review.

Change subject: webadmin: move disks popup - fix alignment
......................................................................

webadmin: move disks popup - fix alignment

Remove redundant/unused panels, labels and styles
(for fixing alignment when using Chrome).

Change-Id: Ibbb9b6cb8b316245463955c43ae30e490224a7b6
Bug-Url: https://bugzilla.redhat.com/893984
Signed-off-by: Daniel Erez <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
2 files changed, 4 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/11217/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
index c7cb7f4..3b846f6 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
@@ -860,12 +860,6 @@
     @DefaultStringValue("Templates")
     String quotaTemplateSubTabLabel();
 
-    @DefaultStringValue("Source")
-    String sourceStorage();
-
-    @DefaultStringValue("Destination")
-    String destinationStorage();
-
     @DefaultStringValue("Disks")
     String diskMainTabLabel();
 
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
index 376898b..c29da6e 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml
@@ -4,52 +4,20 @@
        xmlns:g="urn:import:com.google.gwt.user.client.ui" 
xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
        xmlns:e="urn:import:org.ovirt.engine.ui.webadmin.widget.editor" 
xmlns:w="urn:import:org.ovirt.engine.ui.common.widget.uicommon.storage">
 
-       <ui:with field='constants' 
type='org.ovirt.engine.ui.webadmin.ApplicationConstants' />  
-
        <ui:style>
                .messageLabel {
                        color: #CD2127;
                        text-align: center;
                        padding: 10px;
                }
-               
-               .disksAllocationPanel {
-               }
-               
-               .container {
-                       width: 100%;            
-                       float: right;
-                       margin-bottom: 3px;
-                       border-bottom: 1px solid black;
-                       display: none;
-               }
-               
-               .labelPanel {
-                       float: right;
-               }
-               
-               .label {
-                       font-style: italic;
-                       width: 124px;
-                       margin-left: 6px;
-                       margin-top: 2px;
-               }
        </ui:style>
        
        <d:SimpleDialogPanel width="540px" height="400px">
                <d:content>
-                       <g:VerticalPanel>
-                               <g:SimplePanel 
addStyleNames="{style.container}">
-                                       <g:HorizontalPanel 
addStyleNames="{style.labelPanel}">
-                                               <g:Label 
text="{constants.sourceStorage}" addStyleNames="{style.label}"></g:Label>
-                                               <g:Label 
text="{constants.destinationStorage}" addStyleNames="{style.label}"></g:Label>
-                                       </g:HorizontalPanel>
-                               </g:SimplePanel>
-                               <g:FlowPanel>
-                                       <g:Label ui:field="messageLabel" 
visible="false" addStyleNames="{style.messageLabel}" />
-                                       <w:DisksAllocationView 
ui:field="disksAllocationView" listHeight="280px" listWidth="525px" 
showSource="true" addStyleNames="{style.disksAllocationPanel}" />
-                               </g:FlowPanel>
-                       </g:VerticalPanel>
+                       <g:FlowPanel>
+                               <g:Label ui:field="messageLabel" 
visible="false" addStyleNames="{style.messageLabel}" />
+                               <w:DisksAllocationView 
ui:field="disksAllocationView" listHeight="260px" listWidth="525px" 
showSource="true" />
+                       </g:FlowPanel>
                </d:content>
        </d:SimpleDialogPanel>
        


--
To view, visit http://gerrit.ovirt.org/11217
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbb9b6cb8b316245463955c43ae30e490224a7b6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to