Liron Aravot has posted comments on this change. Change subject: core: prevent failure on concurrent live snapshots ......................................................................
Patch Set 1: Looks good to me, but someone else must approve on a note unrelated to this patch, this command can be changed to be non transactive in a further patch. I guess that we could just lock the VM or add the locked snapshot in a different transaction - as the freelock will "return" as this command will become non transactive - giving +1 as it solves the issue. -- To view, visit http://gerrit.ovirt.org/11206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie745fb194d6cc21ce115fd05ac8c88e852069b74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
