Doron Fediuck has posted comments on this change.
Change subject: engine: different log message for graceful shutdown
......................................................................
Patch Set 3: (1 inline comment)
Other than minor indentation issue, looks ok.
Please fix the indentation and verify.
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
Line 372: }
Line 373: } else {
Line 374: // reports an error for non-responsive server
Line 375: if(new File(pidFile).exists()) {
Line 376: //assumed crash, since the pid file is still there
Since an inner condition added, the try block indentation should be fixed.
Line 377: try {
Line 378:
insertEventIntoAuditLog(AuditLogType.VDC_STOP.name(),
Line 379: AuditLogType.VDC_STOP.getValue(),
Line 380: AuditLogSeverity.ERROR.getValue(),
--
To view, visit http://gerrit.ovirt.org/10875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I409f335fd98959aab4bc1633191a853777b050fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
