Gilad Chaplik has posted comments on this change.
Change subject: Import VM dialog bug fix and cleanup (WIP)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
Line 353:
Line 354: for (Guid templateId : templateDiskMap.keySet()) {
Line 355: for (Disk disk :
templateDiskMap.get(templateId)) {
Line 356: DiskImage diskImage = (DiskImage) disk;
Line 357: if (diskImage.getParentId() != null &&
NGuid.Empty.equals(diskImage.getParentId())) {
IMHO the bug here is || instead of &&... but need to check it out
Line 358: ArrayList<storage_domains>
storageDomains =
Line 359:
templateDisksStorageDomains.get(diskImage.getParentId());
Line 360: if (storageDomains == null) {
Line 361:
missingTemplateDiskMap.put(templateId, templateDiskMap.get(templateId));
--
To view, visit http://gerrit.ovirt.org/10828
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fb5139f43370705081675ab5ffa1552c16c3082
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
