Allon Mureinik has posted comments on this change.
Change subject: core: VM ImageLockd status check in ImagesHandler
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 159: return false;
Line 160: }
Line 161:
Line 162: // Handle VM status with ImageLocked
Line 163: if (getVm().getStatus() == VMStatus.ImageLocked) {
good point, 10x.
Line 164: // without force remove, we can't remove the VM
Line 165: if (!getParameters().getForce()) {
Line 166: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_LOCKED);
Line 167: }
....................................................
Commit Message
Line 3: AuthorDate: 2013-01-19 23:30:15 +0200
Line 4: Commit: Allon Mureinik <[email protected]>
Line 5: CommitDate: 2013-01-20 18:34:39 +0200
Line 6:
Line 7: core: VM ImageLockd status check in ImagesHandler
will fix
Line 8:
Line 9: Since we now have statuses per disk, checking a VM's status for
Line 10: ImageLocked seems unrelated to ImagesHandler.
Line 11: In fact, this has become a more "logical" locked status, not directly
--
To view, visit http://gerrit.ovirt.org/11190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacfcb81df64b778b2093c7c84a8582cfd59be29c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
