Juan Hernandez has posted comments on this change. Change subject: packaging: updated the upgrade to use engine 'maint' mode ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/fedora/setup/basedefs.py Line 156: EXEC_SYSTEMCTL="/bin/systemctl" Line 157: EXEC_SETSEBOOL="/usr/sbin/setsebool" Line 158: EXEC_SEMANAGE="/usr/sbin/semanage" Line 159: EXEC_KEYTOOL="/usr/bin/keytool" Line 160: EXEC_TASK_CLEANER = "/usr/share/ovirt-engine/dbscripts/taskcleaner.sh" Maybe os.path.join(DIR_DB_SCRIPTS, "taskcleaner.sh") ? Line 161: Line 162: CONST_BASE_MAC_ADDR="00:1A:4A" Line 163: CONST_DEFAULT_MAC_RANGE="00:1a:4a:16:84:02-00:1a:4a:16:84:fd" Line 164: CONST_MINIMUM_SPACE_ISODOMAIN=350 -- To view, visit http://gerrit.ovirt.org/11159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4fdd62493085b7ecb4d51fb54e8057418075e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
