Dhandapani Gopal has posted comments on this change.

Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................


Patch Set 8: (1 inline comment)

Incorporated review comment.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 48:          *    and another with replicate volume name, finally combine 
the service details.
Line 49:          */
Line 50: 
Line 51:         if (getParameters().isDetailRequired() || 
StringUtils.isNotEmpty(volumeName)) {
Line 52:             executeAndSetReturnValue(volumeName);
Changed the condition to check isDetailsRequired() == true and volume name is 
not empty.
Line 53:             return;
Line 54:         }
Line 55: 
Line 56:         VDSReturnValue nfsReturnValue = null;


--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to