Selvasundaram has posted comments on this change.
Change subject: engine: Enable gluster hook command
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommand.java
Line 59:
Line 60: if (getParameters().getLevel() == null) {
Line 61:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_HOOK_LEVEL_IS_REQUIRED);
Line 62: return false;
Line 63: }
Done
Line 64:
Line 65: List<Guid> upServerIds = getUpServerIds();
Line 66: if (upServerIds == null || upServerIds.isEmpty()) {
Line 67:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_UP_SERVER_FOUND);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 141: }
Line 142:
Line 143: protected void UpdateHookStatusInDb(Guid clusterId, String
hookName, GlusterHookStatus status) {
Line 144: getGlusterHookDao().updateGlusterHookStatusByName(clusterId,
hookName, status);
Line 145: }
Done
Line 146:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookParameters.java
Line 14: private static final long serialVersionUID = 3398376087476446699L;
Line 15:
Line 16: @NotNull(message = "VALIDATION.GLUSTER.VOLUME.CLUSTER_ID.NOT_NULL")
Line 17: private Guid clusterId;
Line 18:
Done
Line 19: private String hookName;
Line 20:
Line 21: private String glusterCommand;
Line 22:
Line 19: private String hookName;
Line 20:
Line 21: private String glusterCommand;
Line 22:
Line 23: private GlusterHookLevel level;
Done
Line 24:
Line 25: public GlusterHookParameters(Guid clusterId,
Line 26: String hookName,
Line 27: String glusterCommand,
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 306: <include
name="common/businessentities/gluster/MallInfo.java"/>
Line 307: <include
name="common/businessentities/gluster/MemoryStatus.java"/>
Line 308: <include
name="common/businessentities/gluster/Mempool.java"/>
Line 309: <include
name="common/businessentities/gluster/ServiceType.java"/>
Line 310: <include
name="common/businessentities/gluster/GlusterHookLevel.java"/>
Done
Line 311: <include name="common/action/gluster/*.java"/>
Line 312: <include name="common/queries/gluster/*.java"/>
Line 313: <include
name="common/constants/gluster/GlusterConstants.java"/>
Line 314: <include
name="common/utils/gluster/GlusterCoreUtil.java"/>
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 563: new GlusterHookParameters(((GlusterVolumeEntity)
getSelectedItem()).getClusterId(),
Line 564: "_testhook.sh", //$NON-NLS-1$
Line 565: "add-brick", //$NON-NLS-1$
Line 566: GlusterHookLevel.PRE));
Line 567: /**
Yes. I will remove it.
Line 568: ArrayList<VdcActionParametersBase> list = new
java.util.ArrayList<VdcActionParametersBase>();
Line 569: for (Object item : getSelectedItems())
Line 570: {
Line 571: GlusterVolumeEntity volume = (GlusterVolumeEntity) item;
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
