Maor Lipchuk has posted comments on this change.
Change subject: core: Change disks status to illegal.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 284:
Line 285: // If the VM still has disk images related to it, change
their status to Illegal.
Line 286: if (!diskImages.isEmpty()) {
Line 287: for (DiskImage diskImage : diskImages) {
Line 288: if (diskImage.getimageStatus() !=
ImageStatus.ILLEGAL) {
yes, disk could have snapshots
Line 289: log.errorFormat("Disk {0} which is part of VM {1}
was not at ILLEGAL state.",
Line 290: diskImage.getDiskAlias(),
Line 291: getVm().getVmName());
Line 292:
ImagesHandler.updateImageStatus(diskImage.getImage().getId(),
ImageStatus.ILLEGAL);
....................................................
Commit Message
Line 11: Race between live snapshot and VM hibernate,
Line 12: cause results which might be undefined.
Line 13: The proposed fix is adding hibernateVM lock on the VM to avoid this
Line 14: behaviour.
Line 15:
I don't follow
Line 16: Change-Id: Ic4075c03b8d70d50b69222c73169ccc63e3ab66e
Line 17: Related-to: https://bugzilla.redhat.com/880687
--
To view, visit http://gerrit.ovirt.org/11248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4075c03b8d70d50b69222c73169ccc63e3ab66e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
