Einav Cohen has posted comments on this change.
Change subject: webadmin: Use ConfigCommon version in AsyncDataProvider
......................................................................
Patch Set 1:
> I would have split it based on executable units. The GWT is a remote
> application interacting with engine, had we done this better, we would have
> used the restapi to do the communication.
a very old item on our todo list...
> The fact that it is maintained at same tree as engine is something I would
> like to see gone in future :)
right - this is one of the purposes for decoupling.
> The rest api is part of the backend, it is not standalone execution unit,
> right?
right - I wrote it myself in one of my previous comments ("the REST APi is
considered the engine-core's API, therefore it is considered an integral part
of the engine-core, therefore REST API and engine-core wouldn't be decoupled")
- just making sure that decoupling logic is based on something that (I referred
to as) makes sense (== executable units, according to your definition), and
not on something else (== GWT?).
Thanks.
--
To view, visit http://gerrit.ovirt.org/11174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9213aee9182d3bb27fbba04f7163b502438a3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
