Juan Hernandez has posted comments on this change.
Change subject: Shell-In-A-Box UI plugin - adding RPM spec file
......................................................................
Patch Set 2: (1 inline comment)
Forgot another comment about requiring ovirt-engine-backend.
....................................................
File shellbox-plugin/ovirt-engine-shellinabox-uiplugin.spec
Line 5: License: GPL
Line 6: BuildArch: noarch
Line 7: Source0: %{name}-%{version}.tar
Line 8:
Line 9: %define pluginspath /usr/share/ovirt-engine/ui-plugins
As this /usr/share/ovirt-engine/ui-plugins directory is currently owned by the
ovirt-engine-backend package, starting with version 3.3.0 I think that we
should add the following:
Requires: ovirt-engine-backend >= 3.3.0
Line 10:
Line 11: %description
Line 12: ShellBox UI plugin - provides SSH connection to a host using
Line 13: shellinabox - a Web based AJAX terminal emulator
--
To view, visit http://gerrit.ovirt.org/11198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If916c7cf022e9e903cd06e55f7b8ff34851ab9c8
Gerrit-PatchSet: 2
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
