Deepak C Shetty has posted comments on this change.

Change subject: webadmin: Create storage domains using Gluster FS.
......................................................................


Patch Set 8: I would prefer that you didn't submit this

Hi sharad,
    I am using this patchset as a common place to note my comments with regards 
to the entire 'glusterfs' topic patches.

1) After much effort, I was successfully able to get OE compiled with your 
patches, finally!

2) Have not yet tried to create the storage domain. But before that I wanted to 
provide some comments on the UI Dialog that comes up when one selects 
"Data/GlusterFS

    * Under the Path text box it says "Path to device to mount / remote 
export". I think for Gluster its more appropriate if we say "Path to gluster 
volume to mount, typically of the form volfileserver:volname". Maybe Shireesh 
can provide better way of putting this.

    * The VFSType text box has to be read-only with 'glusterfs' pre-filled. I 
think someone had sugested that on the ML and I had put it in the feature page 
on wiki

Will update more once I am able to drive my VDSM changes from this. Thanks.

--
To view, visit http://gerrit.ovirt.org/8983
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74870ea95a103ecdd228a26d314ff66e2fcc675
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to