Alon Bar-Lev has posted comments on this change.

Change subject: build: sync with ovirt-engine build
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File Makefile
Line 63:     ReportsLineBarChartTheme \
Line 64:     ReportsPieChartTheme \
Line 65:     WebadminLineBarChartTheme \
Line 66:     CustomOvirtReportsQueryManipulator \
Line 67:     $(NULL)
we do in makefiles... as you can see...

hmmm... this file is all a mess so add a patch to either use tabs or spaces.

I prefer tabs of course :)))
Line 68: 
Line 69: all: $(BUILD_FILE)
Line 70: 
Line 71: $(BUILD_FILE):


--
To view, visit http://gerrit.ovirt.org/11312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id57e1f74d30eaeda31bd7652f4647c8ae92dadd2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to