Liron Aravot has posted comments on this change.
Change subject: core: RemoveImageParameters - added removeDuringExecution flag
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 81: getParameters().getStorageDomainId()));
Line 82:
Line 83: if (getParameters().isRemoveDuringExecution()
Line 84: && getParameters().getParentCommand() !=
VdcActionType.RemoveVmFromImportExport
Line 85: && getParameters().getParentCommand() !=
VdcActionType.RemoveVmTemplateFromImportExport) {
those command are executing RemoveImage through RemoveAllVmImages, in the case
of remove for import export, no removal from DB is needed at all as the image
is only on the export domain, this command is used just to send the vdsm task
to remove it, so it doesn't need to be removed from DB anyway.
Line 86: removeImageFromDB(false);
Line 87: }
Line 88: } else {
Line 89: log.warn("DiskImage is null, nothing to remove");
--
To view, visit http://gerrit.ovirt.org/11330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ba734a97db220f913bdee88dbfeeba76981f5a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
