Allon Mureinik has posted comments on this change.
Change subject: core: avoid pk violation during import vm
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 128: ACTION_TYPE_FAILED_MISSED_STORAGES_FOR_SOME_DISKS=Cannot ${action}
${type}. Provided destination storage domains don't match for provided disks.
Line 129: ACTION_TYPE_FAILED_STOARGE_DOMAIN_IS_WRONG=Cannot ${action} ${type}.
Provided wrong storage domain, which is not related to disk.
Line 130: ACTION_TYPE_FAILED_VM_IN_PREVIEW=Cannot ${action} ${type}. VM is
previewing a Snapshot.
Line 131: ACTION_TYPE_FAILED_DISKS_LOCKED=Cannot ${action} ${type}: The
following disks are locked: ${diskAliases}. Please try again in a few minutes.
Line 132: ACTION_TYPE_FAILED_IMPORT_DISKS_ALREADY_EXIST=Cannot ${action}
${type}: The following disks already exists: ${diskAliases}. Please import as a
clone.
s/:/./
s/exists/exist/
Line 133: ACTION_TYPE_FAILED_VM_IS_LOCKED=Cannot ${action} ${type}: VM is
locked. Please try again in a few minutes.
Line 134: ACTION_TYPE_FAILED_VM_DURING_EXPORT=Cannot ${action} ${type}: VM is
being exported now. Please try again in a few minutes.
Line 135: ACTION_TYPE_FAILED_VM_IMAGE_IS_ILLEGAL=Cannot ${action} ${type}. VM's
Image might be corrupted.
Line 136: ACTION_TYPE_FAILED_VM_HAS_NO_DISKS=Cannot ${action} ${type}. VM has
no disks.
....................................................
Commit Message
Line 11: it from happening.
Line 12:
Line 13: Bug-Url: https://bugzilla.redhat.com/902040
Line 14: related to Bug-Url: https://bugzilla.redhat.com/890922
Line 15:
please remove this whitespace - it may cause scripts and such not to recognize
this as part of the footer.
Line 16: Change-Id: I84afa8167357b96ce47bc1340a64561a6d232b2d
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 322:
Line 323: @DefaultStringValue("Cannot ${action} ${type}: The following
disks are locked: ${diskAliases}. Please try again in a few minutes.")
Line 324: String ACTION_TYPE_FAILED_DISKS_LOCKED();
Line 325:
Line 326: @DefaultStringValue("Cannot ${action} ${type}: The following
disks already exists: ${diskAliases}. Please import as a clone.")
s/:/./
s/exists/exist/
Line 327: String ACTION_TYPE_FAILED_IMPORT_DISKS_ALREADY_EXIST();
Line 328:
Line 329: @DefaultStringValue("Cannot ${action} ${type}: VM is locked.
Please try again in a few minutes.")
Line 330: String ACTION_TYPE_FAILED_VM_IS_LOCKED();
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 126: DIRECTORY_COMPUTER_WITH_THE_SAME_NAME_ALREADY_EXITS=A Computer with
the same name already exists.
Line 127: VM_NOT_FOUND=VM not found
Line 128: ACTION_TYPE_FAILED_VM_IN_PREVIEW=Cannot ${action} ${type}. VM is
previewing a Snapshot.
Line 129: ACTION_TYPE_FAILED_DISKS_LOCKED=Cannot ${action} ${type}: The
following disks are locked: ${diskAliases}. Please try again in a few minutes.
Line 130: ACTION_TYPE_FAILED_IMPORT_DISKS_ALREADY_EXIST=Cannot ${action}
${type}: The following disks already exists: ${diskAliases}. Please import as a
clone.
s/:/./
s/exists/exist/
Line 131: ACTION_TYPE_FAILED_VM_IS_LOCKED=Cannot ${action} ${type}: VM is
locked. Please try again in a few minutes.
Line 132: ACTION_TYPE_FAILED_VM_DURING_EXPORT=Cannot ${action} ${type}: VM is
being exported now. Please try again in a few minutes.
Line 133: ACTION_TYPE_FAILED_VM_IMAGE_IS_ILLEGAL=Cannot ${action} ${type}. VM's
Image might be corrupted.
Line 134: ACTION_TYPE_FAILED_VM_HAS_NO_DISKS=Cannot ${action} ${type}. VM has
no disks.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 126: VM_NOT_FOUND=VM not found
Line 127: ACTION_TYPE_FAILED_VM_IN_PREVIEW=Cannot ${action} ${type}. VM is
previewing a Snapshot.
Line 128: ACTION_TYPE_FAILED_DISKS_LOCKED=Cannot ${action} ${type}: The
following disks are locked: ${diskAliases}. Please try again in a few minutes.
Line 129: ACTION_TYPE_FAILED_IMPORT_DISKS_ALREADY_EXIST=Cannot ${action}
${type}: The following disks already exists: ${diskAliases}. Please import as a
clone.
Line 130: ACTION_TYPE_FAILED_VM_IS_LOCKED=Cannot ${action} ${type}: VM is
locked. Please try again in a few minutes.
s/:/./
s/exists/exist/
Line 131: ACTION_TYPE_FAILED_VM_DURING_EXPORT=Cannot ${action} ${type}: VM is
being exported now. Please try again in a few minutes.
Line 132: ACTION_TYPE_FAILED_VM_IMAGE_IS_ILLEGAL=Cannot ${action} ${type}. VM's
Image might be corrupted.
Line 133: ACTION_TYPE_FAILED_VM_HAS_NO_DISKS=Cannot ${action} ${type}. VM has
no disks.
Line 134: ACTION_TYPE_FAILED_IMAGE_REPOSITORY_NOT_FOUND=Cannot ${action}
${type}: Storage Domain cannot be accessed.\n\
--
To view, visit http://gerrit.ovirt.org/11332
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84afa8167357b96ce47bc1340a64561a6d232b2d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
