Allon Mureinik has posted comments on this change. Change subject: core: Config mocking in StoragePoolValidatorTest ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 7: core: Config mocking in StoragePoolValidatorTest Line 8: Line 9: Used the standard was of mocking Config - MockConfigRule. Line 10: Line 11: This refactor enabled removing the useless getConfigValue method from Agree - will fix. Line 12: the StoragePoolValidator class, and just call Config.GetValue directly Line 13: instead. Line 14: Line 15: Change-Id: I03c0f2a1c013cd12010be7f84d896c1d1e600c29 -- To view, visit http://gerrit.ovirt.org/11319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c0f2a1c013cd12010be7f84d896c1d1e600c29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
