Vered Volansky has posted comments on this change.
Change subject: core: Refactor SP validation out of ImagesHandler
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 281:
Line 282: @Override
Line 283: protected boolean canDoAction() {
Line 284: VmValidator vmValidator = new VmValidator(getVm());
Line 285: boolean result = validateVM(vmValidator);
Why, oh why, don't you return here?
Line 286: List<DiskImage> disksList = getDisksList();
Line 287: if (result && disksList.size() > 0) {
Line 288: StoragePoolValidator spValidator = new
StoragePoolValidator(getStoragePool());
Line 289: SnapshotsValidator snapshotValidator = new
SnapshotsValidator();
--
To view, visit http://gerrit.ovirt.org/11323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caa3724fb73c8fa8932c8071f6d27a78d681bb3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
