Allon Mureinik has posted comments on this change. Change subject: core: create prop in frontend pom for engine core ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) missed the pom.xml at wars/rmw-war/pom.xml. Also, see inline nitpicking. .................................................... File frontend/pom.xml Line 18: <properties> Line 19: <engine.groupId>org.ovirt.engine.ui</engine.groupId> Line 20: <engine.version>3.2.0</engine.version> Line 21: <aspectj.version>1.6.11</aspectj.version> Line 22: <engine.core.groupId>org.ovirt.engine.core</engine.core.groupId> nitpicking: please group this with engine.groupId above Line 23: </properties> Line 24: <build> Line 25: <pluginManagement> Line 26: <plugins> -- To view, visit http://gerrit.ovirt.org/11365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b4e2886196ae4fdb7580033a83ec651adf1b11 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
