Alon Bar-Lev has posted comments on this change. Change subject: packaging: creating a version file for fetching product version ......................................................................
Patch Set 5: (1 inline comment) .................................................... File Makefile Line 409: # USB filter: Line 410: install -m 644 frontend/usbfilter.txt $(DESTDIR)$(PKG_SYSCONF_DIR) Line 411: Line 412: # Create a version file Line 413: echo $(RPM_VERSION) > $(DESTDIR)$(DATA_DIR)/version well, sorry to bother you... but the /usr/share/ovirt-engine/conf is better. I am thinking of a state in which we would like this version to be independent. Maybe not relay on RPM_VERSION but on APP_DISPLAY_VERSION which is default to APP_VERSION, and override it from the spec file? This will enable us to pass various of packaging version to the build. Line 414: Line 415: install_jboss_modules: Line 416: @echo "*** Deploying JBoss modules" Line 417: -- To view, visit http://gerrit.ovirt.org/11383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I479668e0d82007d283743f732067d58c73d1ea15 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
