Einav Cohen has posted comments on this change. Change subject: webadmin: expand all expands selected node ......................................................................
Patch Set 3: (2 inline comments) .................................................... Commit Message Line 11: - Added logic to find the selected node and pass Line 12: that into the node collapse method. Line 13: - Fixed the node collapse to properly collapse all Line 14: sub nodes AND itself. Line 15: - Merged changes from http://gerrit.ovirt.org/#/c/10427/ Alex - derez is right; no need to mention these kind of things in the commit comment; All "process-related" changes in the patch [i.e. changes done due to code-review comments or due to related code-changes introduced after rebase (i.e. code-changes that happened to be merged before this patch was merged)] - should be documented in the code-review system (i.e. a *gerrit* comment, rather than a *git* commit-comment), once uploading the relevant patch-set that addresses those code-review comments and/or those introduced-related-code-changes after rebase. These comments are interesting to the reviewer, therefore they should be written in the code-review system. The commit-comment should purely describe the purpose of the patch (i.e. what it is coming to solve) and the contents of the patch; someone that will look at the commit-comment two years from now wouldn't really care that this patch was "conformed to changes introduced due to rebase" or "addressed code-review comments" - the git commit comment should always be phrased as if this patch was written in this way "from the beginning", without going through the process. Line 16: - Fixed code review items. Line 17: Line 18: Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879291 Line 12: that into the node collapse method. Line 13: - Fixed the node collapse to properly collapse all Line 14: sub nodes AND itself. Line 15: - Merged changes from http://gerrit.ovirt.org/#/c/10427/ Line 16: - Fixed code review items. Alex- derez is right; see my previous comment. Line 17: Line 18: Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Line 19: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879291 -- To view, visit http://gerrit.ovirt.org/10913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
