Liron Aravot has posted comments on this change.

Change subject: core: AddVdsSpmId - execute for a number of VDSs at once.
......................................................................


Patch Set 3:

Michael, can you elaborate what is complicated in the code?

instead of generating one id -> generating X id
instead of saving one mapping -> save X mapping.

I can add comment where needed..i have no problem with that.

Benefits as i wrote - if updating vds group of 200 hosts, we will take one lock 
instead of 200 global locks, and will load only once from db instead of 200 
loads.

further changes that you need can be done above of this patch.

--
To view, visit http://gerrit.ovirt.org/11412
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ecf9990eeda676ad2a4f9bd73d4535bd2eb3f9a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to