Tal Nisan has posted comments on this change.
Change subject: core: storage domain validation refactoring
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
Line 87: if (getVmTemplate() != null) {
Line 88: setDescription(getVmTemplateName());
Line 89: }
Line 90: StorageDomainValidator storageDomainValidator = new
StorageDomainValidator(getStorageDomain());
Line 91: boolean retVal =
validate(storageDomainValidator.isDomainExistAndActive());
Ok, was just a minor comment anyway, you got a +2 :)
Line 92:
Line 93: if (retVal) {
Line 94: // export must be to export domain
Line 95: if (getStorageDomain().getstorage_domain_type() !=
StorageDomainType.ImportExport) {
--
To view, visit http://gerrit.ovirt.org/11415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64734303de8c9cfaaca4fba6bfeeccc93e18c9a6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
