Alex Lourie has posted comments on this change. Change subject: packaging: suggest path for local storage during AIO setup ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) One small comment. .................................................... File packaging/fedora/setup/plugins/all_in_one_100.py Line 91: def generateLocalStorageDomainName(): Line 92: ''' Line 93: Generates name for local storage domain Line 94: ''' Line 95: if os.path.exists(DEFAULT_LOCAL_STORAGE_PATH): No need to use DEFAULT_ notation. I would just leave it as "LOCAL_STORAGE_PATH". Line 96: return "%s_%s" % (DEFAULT_LOCAL_STORAGE_PATH, Line 97: utils.getCurrentDateTime()) Line 98: else: Line 99: return DEFAULT_LOCAL_STORAGE_PATH -- To view, visit http://gerrit.ovirt.org/11392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb131c3e8d88d6503dc2a03d46fa86590ead52cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
