Moti Asayag has posted comments on this change.
Change subject: engine: Refactored code into NetworkValidator class
......................................................................
Patch Set 6: (1 inline comment)
Except the single comment it's a +1 from me.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
Line 75: return clusterAttachments;
Line 76: }
Line 77:
Line 78: private Network getOldNetwork() {
Line 79: Network newNetwork = getNetwork();
Sorry for missing this earlier - but since the getNetworks() is no longer
needed, we can query for the network by its ID instead getting all networks of
the DC and filter them by network id by replacing the entire body with:
return getNetworkDAO().get(getNetwork().getId());
Line 80: List<Network> networks =
getNetworkDAO().getAllForDataCenter(newNetwork.getDataCenterId());
Line 81:
Line 82: for (Network network : networks) {
Line 83: if (newNetwork.getId().equals(network.getId())) {
--
To view, visit http://gerrit.ovirt.org/10940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
