Allon Mureinik has posted comments on this change.
Change subject: core: handle error when iso domain in maintenance
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 305: if (!refreshSucceeded) {
Line 306: log.debugFormat("Failed refreshing Storage domain id
{0}, for {1} file type in storage pool id {2}.",
Line 307: storageDomainId,
Line 308: fileTypeExt,
Line 309: storagePoolId);
Since you're adding a check after it, this log message will still be logged,
even though it is not true. According to the condifition in line 291, we didn't
even try.
IMHO, you should just change the if line 305 to be if (!refreshSucceeded &&
status=active).
Line 310: if(storagePoolIsoMap.getstatus()!=
StorageDomainStatus.Maintenance) {
Line 311: // set a mock repository file meta data with
storage domain id and storage pool id.
Line 312: RepoFileMetaData repoFileMetaData = new
RepoFileMetaData();
Line 313: repoFileMetaData.setStoragePoolId(storagePoolId);
--
To view, visit http://gerrit.ovirt.org/11449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
