Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Gluster Hooks sub tab in Cluster
......................................................................
Patch Set 4: Looks good to me, approved
(1 inline comment)
minor comment, ack
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
Line 236: }
Line 237:
Line 238: @Override
Line 239: protected void UpdateDetailsAvailability() {
Line 240: super.UpdateDetailsAvailability();
just a thought, in case the items disappear from the grid, this method isn't
called?
Anyway I'd add a null check for getSelectedItem()
Line 241: getClusterServiceModel().setIsAvailable(((VDSGroup)
getSelectedItem()).supportsGlusterService());
Line 242: getClusterGlusterHookListModel().setIsAvailable(((VDSGroup)
getSelectedItem()).supportsGlusterService());
Line 243: }
Line 244:
--
To view, visit http://gerrit.ovirt.org/11235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe5b393c6624d79219cfd9e490e9ddbea9445006
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
