Yair Zaslavsky has posted comments on this change.
Change subject: core: Removal of DNS root from host name
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java
Line 659: System.out.println("Domain " + domain + " is
valid.");
Line 660: }
Line 661: log.info("Successfully tested kerberos configuration
for domain: " + domain);
Line 662: } catch (Exception e) {
Line 663: e.printStackTrace();
I prefer you use the logger here.
Line 664: ManageDomainsResult result =
Line 665: new
ManageDomainsResult(ManageDomainsResultEnum.FAILURE_WHILE_TESTING_DOMAIN,
Line 666: new String[] { domain, e.getMessage()
});
Line 667: if ((isValidate && reportAllErrors) || ((domainName
!= null) && !domain.equals(domainName))) {
--
To view, visit http://gerrit.ovirt.org/11335
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ffafec4853f23a3bfa50793febafbbf97321f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
