Mike Kolesnik has posted comments on this change.
Change subject: engine: Extended error for pinned host missing non required
network
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 109: // we are checking for 2 because the first 2 (0 and
1) are the messaged for
Line 110: // object and action type and we don't want to
override them,
Line 111: // we do override any previous message because this
one has priority.
Line 112: if (messages.size() > 2) {
Line 113: messages.add(2,
So in this case, is there reason to use 2?
Also part of the comment above becomes obsolete.
Line 114:
VdcBllMessages.VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS_WITH_REASON.toString());
Line 115: } else {
Line 116:
messages.add(VdcBllMessages.VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS.toString());
Line 117: }
Line 112: if (messages.size() > 2) {
Line 113: messages.add(2,
Line 114:
VdcBllMessages.VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS_WITH_REASON.toString());
Line 115: } else {
Line 116:
messages.add(VdcBllMessages.VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS.toString());
I am wondering if it would make sense to use the same message here..
What do you think?
Line 117: }
Line 118: return false;
Line 119: }
Line 120: returnValue = canFindAnyVds(messages, isMigrate);
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 153: ACTION_TYPE_FAILED_VM_IS_PINNED_TO_HOST=Cannot ${action} ${type}. VM
is pinned to Host.
Line 154: VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS=Cannot ${action}
${type}. VM is pinned to a specific Host but cannot run on it due to:\n\
Line 155: Invalid Host status or not enough free resources on it.\n\
Line 156: You may free resources on the Host by migrating other VMs.
Line 157: VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS_WITH_REASON = Cannot
${action} ${type}. VM is pinned to a specific Host but cannot run on it.
I'm not sure that spaces around the equals are necessary
Line 158: VM_HOSTCPU_MUST_BE_PINNED_TO_HOST=Cannot ${action} ${type}. VM with
host cpu flags must be pinned to host.
Line 159: ACTION_TYPE_FAILED_VM_NOT_EXIST=Cannot ${action} ${type}. VM doesn't
exist.
Line 160: ACTION_TYPE_FAILED_VM_ALREADY_EXIST=Cannot ${action} ${type}. VM with
the same name already exists.
Line 161:
ACTION_TYPE_FAILED_VM_CANNOT_BE_HIGHLY_AVAILABLE_AND_PINNED_TO_HOST=Cannot
${action} ${type}. A highly available VM cannot be pinned to a specific Host
--
To view, visit http://gerrit.ovirt.org/11338
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9703ae06b06be96c6508d48306d8bd6b8bcfbb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
