Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add Interface dialog is cropped in chrome.
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
Line 153: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 154:
Line 155: // Set Styles
Line 156: checkConnectivity.setContentWidgetStyleName(style.checkCon());
Line 157: mainPanel.getElement().setPropertyString("width", "100%");
//$NON-NLS-1$ //$NON-NLS-2$
consider using style.maxWidth()
Line 158:
Line 159: // Localize
Line 160: bondEditor.setLabel(constants.bondNameHostPopup() + ":");
//$NON-NLS-1$
Line 161: networkEditor.setLabel(constants.networkHostPopup() + ":");
//$NON-NLS-1$
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
Line 152: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 153:
Line 154: // Set Styles
Line 155: isToSync.setContentWidgetStyleName(style.syncInfo());
Line 156: mainPanel.getElement().setPropertyString("width", "100%");
//$NON-NLS-1$ //$NON-NLS-2$
same.
Line 157:
Line 158: // Localize
Line 159: nameEditor.setLabel(constants.nameHostPopup() + ":");
//$NON-NLS-1$
Line 160: networkEditor.setLabel(constants.networkHostPopup() + ":");
//$NON-NLS-1$
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java
Line 157:
Line 158: // Set Styles
Line 159: checkConnectivity.setContentWidgetStyleName(style.checkCon());
Line 160: isToSync.setContentWidgetStyleName(style.syncInfo());
Line 161: mainPanel.getElement().setPropertyString("width", "100%");
//$NON-NLS-1$ //$NON-NLS-2$
same.
Line 162:
Line 163: // Localize
Line 164: nameEditor.setLabel(constants.networkNameInterface() + ":");
//$NON-NLS-1$
Line 165: networkEditor.setLabel(constants.intefaceHostPopup() + ":");
//$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/11460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0e537c9ada3bcc3a0b108228442b59eda9fe26f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
