Alona Kaplan has posted comments on this change.
Change subject: webadmin: improve import conflict (for vm) dialog
......................................................................
Patch Set 4: Looks good to me, approved
(3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelRadioButtonEditor.java
Line 37: // In case we use RadioButton widget label instead of declared
LabelElement,
Line 38: // align content widget container to the left and hide the
LabelElement
Line 39: if (useRadioButtonWidgetLabel) {
Line 40:
getContentWidgetContainer().getElement().getStyle().setFloat(Float.LEFT);
Line 41:
getContentWidgetContainer().getElement().getStyle().setWidth(100, Unit.PCT);
Why do you need this?
Line 42: getLabelElement().getStyle().setDisplay(Display.NONE);
Line 43: }
Line 44: }
Line 45:
Line 83: return super.getLabel();
Line 84: }
Line 85: }
Line 86:
Line 87: @Override
I think you should add new methods- setHTML and getHTML.
When you use setLabel you don't expect it to act as HTML element.
Line 88: public void setLabel(String label) {
Line 89: if (useRadioButtonWidgetLabel) {
Line 90: asRadioButton().setHTML(label);
Line 91: } else {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportCloneDialogPopupView.ui.xml
Line 3: <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
Line 4: xmlns:g="urn:import:com.google.gwt.user.client.ui"
Line 5: xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog"
Line 6: xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor">
Line 7:
please remove trailing whitespaces
Line 8: <ui:style>
Line 9: .innerPanel {
Line 10: padding-left: 30px;
Line 11: }
--
To view, visit http://gerrit.ovirt.org/11435
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6fe863e52e9bad1d620bce75b8252bca4d0d414
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
