Oved Ourfali has posted comments on this change.

Change subject: tools: Adding Setting ldap servers for domain
......................................................................


Patch Set 6: (2 inline comments)

see minor comments

....................................................
File backend/manager/conf/kerberos/engine-manage-domains
Line 52:         printf "\tUSER                          (optional for edit, 
mandatory for add) the domain user.\n"
Line 53:         printf "\tPASSWORD_FILE                 (optional for edit, 
mandatory for add) a file containing the password in the first line.\n"
Line 54:        printf "\tinteractive        alternative for using 
-passwordFile - read the password interactively.\n"
Line 55:         printf "\tPATH               (optional) use the given 
alternate configuration file.\n"
Line 56:         printf "\tLDAP_SERVERS              (optional) a comma 
delimited list of ldap servers to be set to the domain.\n"
s/ldap/LDAP
Line 57:         printf "\n"
Line 58:         printf "\tAvailable actions:\n"
Line 59:         printf "\tadd\n"
Line 60:                printf "\tExamples:\n"


....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 79:                 // base dn, for example: 
ldap://hostname:389/DC=abc,DC=com . However, this URL (ldap:hostname:port)
Line 80:                 // suffices for
Line 81:                 // getting the rootDSE information, which includes the 
baseDN.
Line 82:                 URI uri = locator.constructURI("LDAP", address, 
defaultLdapServerPort);
Line 83:                 System.out.println("!!!debug " + uri + "realm: " + 
this.domainName);
Was is das?
Line 84:                 env.put(Context.PROVIDER_URL, uri.toString());
Line 85:                 ctx = new InitialDirContext(env);
Line 86: 
Line 87:                 // Get the base DN from rootDSE


--
To view, visit http://gerrit.ovirt.org/11065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0904f9f6d9432ecac1cebee2790dae902a1329c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to